MTG Wiki
Advertisement
MTG Wiki
6,039
pages

To many deck calls[]

Core_sets/Preconstructed_theme_decks got auto-categorized into Category:Pages with too many expensive parser function calls. Can we remove some of the logic which causes this behavior? Splitting the page would also be an option. - Yandere Sliver H09 symbol.png 15:39, 30 April 2016 (UTC)

I don't know what MediaWiki considers expensive parser function calls, but the template logic is pretty much minimal for what it's supposed to do. It shouldn't matter much since the template doesn't use anything that circumvents the cache, but if it really bothers you, you could split the page into two, e.g. between 10E and M10. —Fenhl 15:45, 30 April 2016 (UTC)
It might be the use of string manipulation in parser functions (#pos, ucfirst, lc), but I suspect the bigger issue is your nested conditional statements. If you like, I can convert Template:Decks to use a Lua module, which should afford a performance increase. Or, since it appears you're something of a programmer, you're welcome to give it a go yourself. Let me know. --Corveroth (talk) 16:21, 30 April 2016 (UTC)
A lua script would be great. - Yandere Sliver H09 symbol.png 18:04, 30 April 2016 (UTC)
I'm not too familiar with the module system so I'd rather leave this to you. —Fenhl 20:24, 30 April 2016 (UTC)
i tried to change a bit parts using Variables, it does reduce the code a bit, but does not reduce the count of "Expensive parser function count", PS: i also does not know why the pages are listed in "Templates used in this preview:" --Hanmac (talk) 20:35, 30 April 2016 (UTC)

i think the problem is the ifexist of the Deck Pages link ... it did appear when i google after "Expensive parser function" --Hanmac (talk) 20:39, 30 April 2016 (UTC)

Yes, ifexist is painfully expensive and should not be used unless you really really need to. - Yandere Sliver H09 symbol.png 21:44, 30 April 2016 (UTC)
Ah, I didn't even see that when I skimmed through earlier. Still, I'll take a proper look into the code and see if we can streamline things. --Corveroth (talk) 02:38, 1 May 2016 (UTC)

Left you a note asking about intent over here. --Corveroth (talk) 04:24, 1 May 2016 (UTC)

Hi, Fenhl I updated all preconstructed decks pages. I am unsure about removing the redirect target code. I think it can be removed entirely. Or can you think of any use case where it is actually used? - Yandere Sliver H09 symbol.png 20:12, 21 June 2016 (UTC)
I think it should be safe to remove it now. —Fenhl 20:17, 21 June 2016 (UTC)

Token Template[]

I really like it. You should probably also test it in cases where you have if clauses in the template and see if it works there as well. - Yandere Sliver H09 symbol.png 12:42, 3 September 2016 (UTC)

Extension:MTGSCards links[]

Hello. Your request about the links made by the MTGSCards was forwarded to me. So you'd like the links changed from http://magiccards.info/ to using http://mtg.wtf/, or for which site is used to be a user preference? --Sigilbaram (talk) 14:12, 14 November 2016 (UTC)

Either would be helpful. This has not been discussed with the admins though. And mtg.wtf also supports HTTPS. —Fenhl 16:06, 14 November 2016 (UTC)
Hi. The Admins did speak about this. Our preferred database is the MTGS database (In other words our own). We lost affiliation with magiccards.info long time ago. That goes by the way for the c-tags and the d-tags as well. - Yandere Sliver H09 symbol.png 17:28, 14 November 2016 (UTC)
Would a user preference still be a possibility? The MTGS database has none of the search features I regularly use. —Fenhl 17:43, 14 November 2016 (UTC)
I am not quite sure which features are missing, but you can probably request them in the forums. On user preference I can't really comment, that seems like a thing that Sigelbaram could possibly answer. - Yandere Sliver H09 symbol.png 18:59, 14 November 2016 (UTC)
You always bring up the forums. Why can't we discuss the wiki on the wiki? —Fenhl 19:04, 14 November 2016 (UTC)
I actually agree on that... I think it is best to discuss the wiki on the wiki, but other people liked the forums better. That is why to connect with other people editing in the wiki, I always point towards the forums. But that is a bit of a different discussion. - Yandere Sliver H09 symbol.png 19:17, 14 November 2016 (UTC)
For various reasons, I completely stopped using the forums a while ago. My preference would now be to use the Wiki too, but I do understand it if other editors prefer the forums. --Sene (talk) 19:41, 14 November 2016 (UTC)

(Resetting Indent) Sorry for the delay. A user preference might be possible, it would depend on what our dev team can do with it. One thing that might make it difficult is that the URL format for each site tends to be different. Another reason http://www.mtgsalvation.com/ might be nice is that our dev team has access to both sides, so they might be able to make sure things line up or maybe introduce some new features on both ends. I'll get in touch with them and let you guys know. --Sigilbaram (talk) 16:07, 21 November 2016 (UTC)

Sorry to abuse your page, Fenhl, but I'm running into use cases where this is relevant again. Not just in terms of where we're linking, but also in terms of exactly what functionality we get out of the link (as has been discussed at various points over the last year or so). Can we get tooltips like the forum has? The option of inlining card images via the name or multiverse ID, without needing to upload them here separately? These range from simple convenience to transformative changes. --Corveroth (talk) 00:36, 18 December 2016 (UTC)
Yes, card pictures on hover would be a-MEI-zing. - Yandere Sliver H09 symbol.png 00:48, 18 December 2016 (UTC)
Get your Wall of Frost out of here. =P But yes. Also, I'd love to try to implement something like a deck viewer, similar to the one on MTGTop8, for example. --Corveroth (talk) 00:52, 18 December 2016 (UTC)